Conversation
The first auto-commit path trusted parent git diff, but real parent workspaces can set diff.ignoreSubmodules=all. That hides exactly the gitlink drift this feature needs to commit, so detection now compares the parent gitlink index SHA to the nested repo HEAD and parent HEAD tree entry. Constraint: Parent workspaces may intentionally hide submodule noise in normal status output. Rejected: Disable diff.ignoreSubmodules temporarily | mutates parent repo configuration and still leaves hidden-index edge cases. Confidence: high Scope-risk: narrow Directive: Keep gitlink drift detection SHA-based; do not rely on git diff status for subrepo pointer updates. Tested: bash -n scripts/agent-branch-finish.sh; bash -n templates/scripts/agent-branch-finish.sh; node --test test/finish.test.js; openspec validate agent-codex-auto-commit-parent-subrepo-upgrades-2026-04-23-11-59 --strict; git diff --check Not-tested: Full npm test after follow-up; full suite passed before this narrow SHA-detection fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).